techniker-me/personal-finance
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor asset type handling in AssetController schema

Browse Source 
- Replaced native enum for asset types with a constant array using z.enum for improved type safety and maintainability in create and update asset schemas.
This commit is contained in:
Alexander Zinn
2025-12-08 02:57:49 -05:00
parent 700832550c
commit ca5a13ea51
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
backend-api/src/controllers/AssetController.ts
View File

@@ -3,17 +3,18 @@ import {z} from 'zod';
import {AssetService} from '../services/AssetService'; import {AssetService} from '../services/AssetService';
import {AssetRepository} from '../repositories/AssetRepository'; import {AssetRepository} from '../repositories/AssetRepository';
import {getUserId} from '../middleware/auth'; import {getUserId} from '../middleware/auth';
type AssetType = 'cash' | 'investment' | 'property' | 'vehicle' | 'other';
const ASSET_TYPES = ['cash', 'investment', 'property', 'vehicle', 'other'] as const;
const createAssetSchema = z.object({ const createAssetSchema = z.object({
name: z.string().min(1), name: z.string().min(1),
type: z.nativeEnum(AssetType), type: z.enum(ASSET_TYPES),
value: z.number().min(0), value: z.number().min(0),
}); });
const updateAssetSchema = z.object({ const updateAssetSchema = z.object({
name: z.string().min(1).optional(), name: z.string().min(1).optional(),
type: z.nativeEnum(AssetType).optional(), type: z.enum(ASSET_TYPES).optional(),
value: z.number().min(0).optional(), value: z.number().min(0).optional(),
}); });